Revert "Update BundleUpload status for observability" #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f81ac92.
|
✅ 86 passed ⋅ (learn more) |
|
We can definitely add tests that assert the test should fail—testing both happy and sad paths: analytics-cli/cli/tests/upload.rs Lines 64 to 65 in f81ac92 |
max-trunk
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Sorry about this! Was able to reproduce the error log when invoking an upload against staging
max@max-cloudtop:~/src/flake-factory$ TRUNK_PUBLIC_API_ADDRESS=https://api.trunk-staging.io:443 ~/src/analytics-cli/target/x86_64-unknown-linux-musl/release/trunk-analytics-cli upload --org-url-slug trunk-staging-org --token 8ee28021f4e9168f075c20ef732fbb475599c5d0 --junit-paths "**/gotestsum_test.xml"
2024-10-03T12:29:01 [INFO] - Reading git repo at "/home/max/src/flake-factory"
2024-10-03T12:29:01 [INFO] - Found git_url: Some("git@github.com:trunk-io/flake-factory.git")
2024-10-03T12:29:01 [INFO] - Found git_sha: Some("e9665845818c1902ada378ff620dcc5101d1a1bf")
2024-10-03T12:29:01 [INFO] - Found git_branch: Some("refs/heads/main")
2024-10-03T12:29:01 [INFO] - Found git_commit_time: Time { seconds: 1727892546, offset: -25200, sign: Minus }
2024-10-03T12:29:01 [INFO] - Found git_commit_message: Some("Merge pull request #8393 from trunk-io/add-karma-framework")
2024-10-03T12:29:01 [INFO] - Found git_author: Some(HeadAuthor { name: "Josh Marinacci", email: "276938+joshmarinacci@users.noreply.github.com" })
2024-10-03T12:29:01 [INFO] - Starting trunk-analytics-cli 0.0.0 (git=f81ac924d5687b4cd1115709fa673ba06088d9a6) rustc=1.80.0-nightly
2024-10-03T12:29:02 [INFO] - Total files pack and upload: 1
2024-10-03T12:29:02 [INFO] - Total bytes in: 4568, total bytes out: 2154 (size reduction: 52.85%)
2024-10-03T12:29:02 [INFO] - Flushed temporary tarball to "/tmp/.tmp6LV7bk/bundle.tar.zstd"
2024-10-03T12:29:22 [WARN] - Failed to update bundle upload status to UploadComplete: Failed to update bundle upload status
2024-10-03T12:29:22 [INFO] - Done
But I do see the resulting row with its status correctly updated in the metrics db
But also, the CLI invocation was much slower - is it possible there's some timeout getting triggered in one of the services?
I think it makes sense to revert for now while we sort this out. I could see us needing to add / revise an index on bundle_upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #99
I've narrowed down a breakage that I've been seeing locally to this PR. It is the first time uploads start to fail in the check and it makes changes to the area of code in question.
https://github.com/trunk-io/analytics-cli/actions/runs/11113171931/job/30876881217#step:9:26
It wasn't caught because we're returning exit code 0 even when the upload fails. So the job looked like it passed. We need to add a mode that forces fail on any error so we can better test the cli.
I'm putting up a revert in case the actual fix is non trivial. Feel free to close this if we can get a proper fix in in a timely manner.
After revert everything looks as expected: